From 29394dea5e1303cdf07337d39c2c93249fdd41db Mon Sep 17 00:00:00 2001 From: Jonas Gloning <34194370+jonasgloning@users.noreply.github.com> Date: Thu, 17 Nov 2022 20:58:06 +0100 Subject: [PATCH] fix: the server could crash if a client sends invalid frames --- src/services/webSocketServer/index.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/services/webSocketServer/index.ts b/src/services/webSocketServer/index.ts index 553d46b..a2c335e 100644 --- a/src/services/webSocketServer/index.ts +++ b/src/services/webSocketServer/index.ts @@ -47,6 +47,9 @@ export class WebSocketServer extends EventEmitter implements IWebSocketServer { } private _onSocketConnection(socket: WebSocket, req: IncomingMessage): void { + // An unhandled socket error might crash the server. Handle it first. + socket.on("error", error => this._onSocketError(error)) + const { query = {} } = url.parse(req.url ?? '', true); const { id, token, key }: IAuthParams = query;