add eslint

fix npm audit

.eslintrc.json

@@ -0,0 +1,19 @@
+{
+    "extends": [
+        "eslint:recommended"
+    ],
+    "env": {
+        "node": true,
+        "es6": true,
+        "mocha": true
+    },
+    "parserOptions": {
+        "ecmaVersion": 2018,
+        "sourceType": "module",
+        "allowImportExportEverywhere": true
+    },
+    "rules": {
+        "no-var": "error",
+        "no-console": "off"
+    }
+}

package.json

@@ -13,7 +13,7 @@
   "author": "Michelle Bu, Eric Zhang",
   "license": "MIT",
   "scripts": {
-    "test": "mocha test/**/*.js",
+    "test": "eslint . && mocha test/**/*.js",
     "start": "bin/peerjs --port ${PORT:=9000}"
   },
   "dependencies": {
@@ -25,7 +25,8 @@
   },
   "devDependencies": {
     "chai": "^4.2.0",
-    "mocha": "^6.1.2",
+    "eslint": "^6.2.1",
+    "mocha": "^6.2.0",
     "semistandard": "^13.0.1",
     "sinon": "^7.3.1"
   },

src/api/index.js

@@ -12,7 +12,7 @@ module.exports = ({ config, realm, messageHandler }) => {
 
   app.use(cors());
 
-  app.get('/', (req, res, next) => {
+  app.get('/', (req, res) => {
     res.send(publicContent);
   });
 

src/api/v1/public/index.js

@@ -4,13 +4,13 @@ module.exports = ({ config, realm }) => {
   const app = express.Router();
 
   // Retrieve guaranteed random ID.
-  app.get('/id', (req, res, next) => {
+  app.get('/id', (req, res) => {
     res.contentType = 'text/html';
     res.send(realm.generateClientId());
   });
 
   // Get a list of all peers for a key, enabled by the `allowDiscovery` flag.
-  app.get('/peers', (req, res, next) => {
+  app.get('/peers', (req, res) => {
     if (config.allow_discovery) {
       const clientsIds = realm.getClientsIds();
 

src/index.js

@@ -2,7 +2,7 @@ const express = require('express');
 const http = require('http');
 const https = require('https');
 
-const config = require('../config');
+const defaultConfig = require('../config');
 const WebSocketServer = require('./services/webSocketServer');
 const Realm = require('./models/realm');
 
@@ -28,6 +28,7 @@ const init = ({ app, server, options }) => {
 
     if (messageQueue) {
       let message;
+      // eslint-disable-next-line no-cond-assign
       while (message = messageQueue.readMessage()) {
         messageHandler(client, message);
       }
@@ -53,11 +54,11 @@ const init = ({ app, server, options }) => {
   startMessagesExpiration();
 };
 
-function ExpressPeerServer (server, options) {
+function ExpressPeerServer(server, options) {
   const app = express();
 
   options = {
-    ...config,
+    ...defaultConfig,
     ...options
   };
 
@@ -77,11 +78,11 @@ function ExpressPeerServer (server, options) {
   return app;
 }
 
-function PeerServer (options = {}, callback) {
+function PeerServer(options = {}, callback) {
   const app = express();
 
   options = {
-    ...config,
+    ...defaultConfig,
     ...options
   };
 

src/messageHandler/index.js

@@ -1,7 +1,7 @@
 const { MessageType } = require('../enums');
 
 class MessageHandlers {
-  constructor ({ realm }) {
+  constructor () {
     this.handlers = {};
   }
 
@@ -24,7 +24,7 @@ class MessageHandlers {
 module.exports = ({ realm }) => {
   const transmissionHandler = require('./handlers/transmission')({ realm });
 
-  const messageHandlers = new MessageHandlers({ realm });
+  const messageHandlers = new MessageHandlers();
 
   const handleTransmission = (client, message) => {
     transmissionHandler(client, {
@@ -35,7 +35,7 @@ module.exports = ({ realm }) => {
     });
   };
 
-  const handleHeartbeat = (client, message) => {
+  const handleHeartbeat = () => {
 
   };
 

src/services/webSocketServer/index.js

@@ -5,7 +5,7 @@ const { MessageType, Errors } = require('../../enums');
 const Client = require('../../models/client');
 
 class WebSocketServer extends EventEmitter {
-  constructor ({ server, realm, config }) {
+  constructor({ server, realm, config }) {
     super();
     this.setMaxListeners(0);
     this.realm = realm;
@@ -20,7 +20,7 @@ class WebSocketServer extends EventEmitter {
     this._wss.on('error', (error) => this._onSocketError(error));
   }
 
-  _onSocketConnection (socket, req) {
+  _onSocketConnection(socket, req) {
     const { query = {} } = url.parse(req.url, true);
 
     const { id, token, key } = query;
@@ -52,12 +52,12 @@ class WebSocketServer extends EventEmitter {
     this._registerClient({ socket, id, token });
   }
 
-  _onSocketError (error) {
+  _onSocketError(error) {
     // handle error
     this.emit('error', error);
   }
 
-  _registerClient ({ socket, id, token }) {
+  _registerClient({ socket, id, token }) {
     // Check concurrent limit
     const clientsCount = this.realm.getClientsIds().length;
 
@@ -72,7 +72,7 @@ class WebSocketServer extends EventEmitter {
     this._configureWS(socket, newClient);
   }
 
-  _configureWS (socket, client) {
+  _configureWS(socket, client) {
     client.setSocket(socket);
 
     // Cleanup after a socket closes.
@@ -92,14 +92,14 @@ class WebSocketServer extends EventEmitter {
 
         this.emit('message', client, message);
       } catch (e) {
-        throw e;
+        this.emit('error', e);
       }
     });
 
     this.emit('connection', client);
   }
 
-  _sendErrorAndClose (socket, msg) {
+  _sendErrorAndClose(socket, msg) {
     socket.send(
       JSON.stringify({
         type: MessageType.ERROR,