From fc15be85a0054cd4bb071ba3e99ec33b74bc8703 Mon Sep 17 00:00:00 2001 From: Oj Date: Tue, 7 Feb 2023 13:28:16 +0000 Subject: [PATCH] launcher: explain close process --- src/launcher/inject.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/launcher/inject.js b/src/launcher/inject.js index 5bcdf3d..0da2db8 100644 --- a/src/launcher/inject.js +++ b/src/launcher/inject.js @@ -198,9 +198,9 @@ export default async (CDP, proc, injectionType = 'browser', { dataPath, browserN for (const handler of closeHandlers) handler(); // extra api handlers which need to be closed - CDP.sendMessage('Browser.close'); - CDP.close(); - proc.kill(); + CDP.sendMessage('Browser.close'); // request graceful close to browser (incase process is not attached) + CDP.close(); // close CDP connection + proc.kill(); // kill browser process return Window.closed = true; },